fix: ensure min, max dates have correct format #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhealy1
requested changes
Nov 27, 2025
Collaborator
jonhealy1
left a comment
jonhealy1
left a comment
There was a problem hiding this comment.
Should line 78 look like this for consistency?
datetime_iso = dt_utc.isoformat().replace("+00:00", "Z")
| # Ensure datetimes are converted to UTC and formatted with 'Z' | ||
| if start: | ||
| result["gte"] = start.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3] + "Z" | ||
| result["gte"] = start_utc.isoformat().replace("+00:00", "Z") |
Collaborator
There was a problem hiding this comment.
This should be start.isoformat() not start_utc.isoformat() I think
Collaborator
Author
There was a problem hiding this comment.
fixed, thank you!
| result["gte"] = start_utc.isoformat().replace("+00:00", "Z") | ||
| if end: | ||
| result["lte"] = end.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3] + "Z" | ||
| result["lte"] = end_utc.isoformat().replace("+00:00", "Z") |
Collaborator
There was a problem hiding this comment.
Same here - end_utc has not been defined in this block
Collaborator
Author
There was a problem hiding this comment.
fixed, thank you!
YuriZmytrakov
force-pushed
the
CAT-1619
branch
from
516f92a to
79e1e56
Compare
Collaborator
Author
Yes, thank you, fixed this too. |
YuriZmytrakov
force-pushed
the
CAT-1619
branch
from
5dba133 to
58d4ff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, the
minandmaxdates used inapply_datetime_filterforPOSTrequests are not formatted correctly. This PR fixes the issue:PR Checklist:
pre-commit run --all-files)make test)