Skip to content

Conversation

@StijnCaerts
Copy link
Collaborator

@StijnCaerts StijnCaerts commented Dec 4, 2025

Related Issue(s):
N/A

Description:
Fixes an unawaited coroutine:

stac_fastapi/core/core.py:762: RuntimeWarning: coroutine 'Request.body' was never awaited
  if request.method == "POST" and request.body():

request.body() always had a bool value of True as it is the coroutine, not the result.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@jonhealy1 jonhealy1 self-requested a review December 4, 2025 15:46
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StijnCaerts

@jonhealy1 jonhealy1 merged commit f99c6e6 into main Dec 4, 2025
8 checks passed
@jonhealy1 jonhealy1 deleted the fix/await-coroutine branch December 4, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants