Skip to content

Conversation

@Zaczero
Copy link
Contributor

@Zaczero Zaczero commented Oct 28, 2025

Change request_response import from starlette.routing to fastapi.routing in both routes.py and openapi.py to use FastAPI's enhanced version with AsyncExitStack support for dependencies with yield.

Remove upper version constraint on FastAPI (<0.118.0) to allow users to upgrade to FastAPI 0.119.0 and later versions.

In FastAPI 0.119.0, request_response is no longer a re-export from Starlette but a custom implementation with additional functionality for proper dependency lifecycle management.

Fixes #856

🤖 Generated with Claude Code

Related Issue(s):

Description:

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

Change request_response import from starlette.routing to fastapi.routing
in both routes.py and openapi.py to use FastAPI's enhanced version with
AsyncExitStack support for dependencies with yield.

Remove upper version constraint on FastAPI (<0.118.0) to allow users to
upgrade to FastAPI 0.119.0 and later versions.

In FastAPI 0.119.0, request_response is no longer a re-export from
Starlette but a custom implementation with additional functionality for
proper dependency lifecycle management.

Fixes stac-utils#856

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@vincentsarago vincentsarago self-requested a review October 28, 2025 13:21
Copy link
Member

@vincentsarago vincentsarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🙏

@vincentsarago vincentsarago merged commit 2b0c234 into stac-utils:main Oct 28, 2025
7 of 8 checks passed
@Zaczero Zaczero deleted the claude/session-011CUZTAhB4tgHthZHm2hXuK branch October 28, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FastAPI 0.119.0 breaks direct response

3 participants