Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

- support for python 3.9 and 3.10

### Fixed

- fixed output type for `api.models.create_request_model` and `api.models.create_get_request_model` methods

## [6.1.1] - 2025-11-23

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions stac_fastapi/api/stac_fastapi/api/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def create_request_model(
extensions: Optional[List[ApiExtension]] = None,
mixins: Optional[Union[List[Type[BaseModel]], List[Type[APIRequest]]]] = None,
request_type: Optional[str] = "GET",
) -> Union[Type[BaseModel], APIRequest]:
) -> Union[Type[BaseModel], Type[APIRequest]]:
"""Create a pydantic model for validating request bodies."""
fields = {}
extension_models = []
Expand Down Expand Up @@ -65,7 +65,7 @@ def create_request_model(
def create_get_request_model(
extensions: Optional[List[ApiExtension]],
base_model: BaseSearchGetRequest = BaseSearchGetRequest,
) -> APIRequest:
) -> Type[APIRequest]:
"""Wrap create_request_model to create the GET request model."""

return create_request_model(
Expand Down
11 changes: 9 additions & 2 deletions stac_fastapi/api/tests/test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,24 @@
import pytest
from fastapi import Depends, FastAPI, HTTPException
from fastapi.testclient import TestClient
from pydantic import ValidationError
from pydantic import BaseModel, ValidationError

from stac_fastapi.api.models import create_get_request_model, create_post_request_model
from stac_fastapi.extensions.core import FieldsExtension, FilterExtension, SortExtension
from stac_fastapi.types.search import BaseSearchGetRequest, BaseSearchPostRequest
from stac_fastapi.types.search import (
APIRequest,
BaseSearchGetRequest,
BaseSearchPostRequest,
)


def test_create_get_request_model():
request_model = create_get_request_model(
extensions=[FilterExtension(), FieldsExtension()],
base_model=BaseSearchGetRequest,
)
assert type(request_model) is type
assert issubclass(request_model, APIRequest)

model = request_model(
collections="test1,test2",
Expand Down Expand Up @@ -96,6 +102,7 @@ def test_create_post_request_model(filter_val, passes):
extensions=[FilterExtension(), FieldsExtension()],
base_model=BaseSearchPostRequest,
)
assert issubclass(request_model, BaseModel)

if not passes:
with pytest.raises(ValidationError):
Expand Down
Loading
Loading