Next link generated in search results causes JSON parse error

[kbgg]

When the result for the collection/items endpoint is returned, it includes a link to fetch the next page of results which looks like this:
https://api.server.com/collections/some_collection/items?collections=some_collection&page=2&limit=10

When navigating to this link, this error is generated:
Unexpected token r in JSON at position 0

It looks like the collections parameter is expected to be a JSON array of strings rather than just a single string causing a JSON parsing error.

[matthewhanson]

thanks for this @kbgg

Ah, I see - the collections query parameter is expected to be an array, so this is treating the single string as an array.
The proper way to do this is to indicate the collections parameter is an array by specifying:
collections[]
e.g.,
https://1tqdbvsut9.execute-api.us-west-2.amazonaws.com/v0/collections/sentinel-s2-l2a/items?collections[]=sentinel-s2-l2a&page=2&limit=10

Working on a fix.

[matthewhanson]

I pushed the fix above but not sure it's the best way. If the result is a /search rather than the items collection and there are multiple collections this may not work.

In actuality this isn't actually STAC compliant, the next link in STAC actually should contain a next token and it's up to the user to re-POST the original query.

Going to investigate a quick better way to do this with keeping it as a GET request, but ultimately it should implement the re-POST approach in STAC.