Sv 140 - add FastAPI to lambda and a GET route for stac urls #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbants
requested changes
Apr 26, 2021
Collaborator
jbants
left a comment
jbants
left a comment
There was a problem hiding this comment.
Looks good. Good idea!
Some minor naming change stuff
| ) | ||
|
|
||
| # Defines an AWS Lambda resource | ||
| validator_lambda = _lambda.Function( |
Collaborator
There was a problem hiding this comment.
Let's leave this as validator lambda.
| from aws_cdk import core as cdk | ||
|
|
||
|
|
||
| class ValidatorCdkStack(cdk.Stack): |
Collaborator
There was a problem hiding this comment.
Let's leave this as ValidatorCDKStack
| validator_lambda = _lambda.Function( | ||
| fast_api_lambda = _lambda.Function( | ||
| self, | ||
| "STACHandler", |
| apigw.LambdaRestApi( | ||
| self, | ||
| "Endpoint", | ||
| handler=validator_lambda, |
jbants
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements openapi documentation by default which is one of the issues for a 2.0.0 release. It also provides better routing. There is a demo running here: https://u13x8zu0t0.execute-api.us-west-2.amazonaws.com/prod/docs
Resolves: #140