Skip to content

Error messaging #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 31, 2021
Merged

Error messaging #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34be9e4
[error_messaging] added better error messaging
jbants Apr 10, 2020
979547a
[error_messaging] capture array position in error messaging
jbants Apr 10, 2020
d5a7f7c
[error_messaging] check version string
jbants Apr 10, 2020
4baea37
[error_messaging] updated error message testing
jbants Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions stac_validator/stac_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ def __init__(
level=numeric_log_level,
)
logging.info("STAC Validator Started.")
self.stac_version = version
if version in ['master', 'latest'] or version.startswith("v"):
self.stac_version = version
else:
self.stac_version = f"v{version}"
self.stac_file = stac_file.strip()
self.dirpath = tempfile.mkdtemp()
self.stac_spec_host = stac_spec_host
Expand Down Expand Up @@ -205,7 +208,11 @@ def run(self):
message["valid_stac"] = True
except ValidationError as e:
self.status[f"{self.stac_type}s"]["invalid"] += 1
message.update(self.create_err_msg("ValidationError", e.message))
if e.absolute_path:
err_msg = f"{e.message}. Error is in {' -> '.join([str(i) for i in e.absolute_path])}"
else:
err_msg = f"{e.message} of the root of the STAC object"
message.update(self.create_err_msg("ValidationError", err_msg ))

self.message.append(message)

Expand Down
2 changes: 1 addition & 1 deletion tests/test_stac_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def test_bad_item_validation_v090_verbose():
"schema": "https://cdn.staclint.com/v0.9.0/item.json",
"valid_stac": False,
"error_type": "ValidationError",
"error_message": "'id' is a required property",
"error_message": "'id' is a required property of the root of the STAC object",
}
]

Expand Down