Skip to content

Conversation

@rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Nov 8, 2019

As cmake expects absolute library paths, while pkgconfig provides lib names only (together with
LIBRARY_DIRS), one needs to transform names to full library paths.

This fixes 7854c0f / #101. Without this fix, the MoveIt catkin build still fails with:

Errors     << moveit_ros_planning_interface:make /vol/sandbox/ros/logs/moveit_ros_planning_interface/build.make.000.log
/usr/bin/ld: cannot find -leigenpy
collect2: error: ld returned 1 exit status

As cmake expects absolute library paths, while pkgconfig provides lib names only (together with
LIBRARY_DIRS), one needs to find the full library path.

This fixes 7854c0f.
@wxmerkt
Copy link
Member

wxmerkt commented Nov 8, 2019

Thank you for the fix @rhaschke. I think this is neater than #108, which also works in compiling MoveIt.

@rhaschke
Copy link
Contributor Author

rhaschke commented Nov 8, 2019

Yeah, using link_directories is "bad" style, because it might introduce unintended side effects.

@rhaschke
Copy link
Contributor Author

rhaschke commented Nov 8, 2019

@wxmerkt, maybe you want to close #108 in favor of this PR?

Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhaschke Thanks for the fix. I will merge it.

@jcarpent jcarpent changed the base branch from master to devel November 8, 2019 09:16
@jcarpent jcarpent merged commit bfafada into stack-of-tasks:devel Nov 8, 2019
@rhaschke
Copy link
Contributor Author

rhaschke commented Nov 8, 2019

Thanks for this quick merge!
@wxmerkt, can you please prepare a new (Kinetic and Melodic) release to fix the issues on the ROS build farm? Thanks.

@jcarpent
Copy link
Contributor

jcarpent commented Nov 8, 2019

I will handle it ;)

@wxmerkt
Copy link
Member

wxmerkt commented Nov 9, 2019

Kinetic: ros/rosdistro#22934
Melodic: ros/rosdistro#22935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants