-
Notifications
You must be signed in to change notification settings - Fork 47
Improve packaging and export of the project #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for the great effort. I will check it either tomorrow or Monday (and also check that it doesn't break MoveIt) |
|
@wxmerkt I've added a unit test of using the new export. It seems to work well. |
|
@wxmerkt A kind reminder. If you have time today to check this PR ;) |
|
I have just tested it and it appears to work. However, please note: The install path for the |
Is it an issue? |
|
It appears to work - we should note it in case someone comes back in future if it breaks something. From me, this PR is good to go |
|
Do you want me to install it in the share folder too? |
|
No, let's leave it as is (no duplication) until we have a use case that requires it |
|
@wxmerkt Thanks a lot for your nice feedback. |
@wxmerkt I have implemented the full export of the project. It should work now. Could you check that the export is working well?
Before merging and making a new release, I will implement a small unit test to check the export is working well too.