Skip to content

Fix issues for Windows #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Fix issues for Windows #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
980055e
core: minor fix
jcarpent Jan 30, 2020
5c367b6
core: minor clean
jcarpent Jan 30, 2020
3607ba2
core: add missing include for Windows
jcarpent Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions python/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,7 @@ BOOST_PYTHON_MODULE(eigenpy)
"Returns True if A is approximately equal to B, within the precision determined by prec.");
bp::def("is_approx",(bool (*)(const MatrixXd &, const MatrixXd &))&is_approx<MatrixXd,MatrixXd>,
bp::args("A","B"),
"Returns True if A is approximately equal to B..");

// EXPOSE_IS_APPROX(MatrixXd);
// EXPOSE_IS_APPROX(MatrixXf);
"Returns True if A is approximately equal to B.");
}

exposeDecompositions();
Expand Down
11 changes: 6 additions & 5 deletions src/decompositions/decompositions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
#include <boost/python.hpp>
#include <Eigen/Core>

#include "eigenpy/decompositions/decompositions.hpp"

#include "eigenpy/decompositions/EigenSolver.hpp"
#include "eigenpy/decompositions/SelfAdjointEigenSolver.hpp"
#include "eigenpy/decompositions/LLT.hpp"
Expand All @@ -17,13 +19,12 @@ namespace eigenpy
using namespace Eigen;
namespace bp = boost::python;

EigenSolverVisitor<Eigen::MatrixXd>::expose("EigenSolver");
SelfAdjointEigenSolverVisitor<Eigen::MatrixXd>::expose("SelfAdjointEigenSolver");
LLTSolverVisitor<Eigen::MatrixXd>::expose("LLT");
LDLTSolverVisitor<Eigen::MatrixXd>::expose("LDLT");
EigenSolverVisitor<MatrixXd>::expose("EigenSolver");
SelfAdjointEigenSolverVisitor<MatrixXd>::expose("SelfAdjointEigenSolver");
LLTSolverVisitor<MatrixXd>::expose("LLT");
LDLTSolverVisitor<MatrixXd>::expose("LDLT");

{
using namespace Eigen;
bp::enum_<DecompositionOptions>("DecompositionOptions")
.value("ComputeFullU",ComputeFullU)
.value("ComputeThinU",ComputeThinU)
Expand Down