break circular include #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise, when a user include directly this header without fwd.hpp, as
in the include.cpp regression test:
Dans le fichier inclus depuis ../include/eigenpy/fwd.hpp:35,
depuis ../include/eigenpy/registration.hpp:9,
depuis ../unittest/include.cpp:7:
../include/eigenpy/expose.hpp: Dans la fonction « void eigenpy::expose() »:
../include/eigenpy/expose.hpp:27:9: erreur: « register_symbolic_link_to_registered_type » n'a pas été déclaré dans cette portée
27 | if(!register_symbolic_link_to_registered_type<T>())
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/eigenpy/expose.hpp:27:52: erreur: expected primary-expression before « > » token
27 | if(!register_symbolic_link_to_registered_type<T>())
| ^
../include/eigenpy/expose.hpp:27:50: attention: le non logique est toujours appliqué au membre de gauche de la comparaison [-Wlogical-not-parentheses]
27 | if(!register_symbolic_link_to_registered_type<T>())
| ^
../include/eigenpy/expose.hpp:27:54: erreur: expected primary-expression before « ) » token
27 | if(!register_symbolic_link_to_registered_type<T>())
| ^
Contributor
Author
|
And here is the fix, the CI should pass :) |
jcarpent
reviewed
May 25, 2021
Contributor
jcarpent
left a comment
jcarpent
left a comment
There was a problem hiding this comment.
I don't understand the effect of this change. Please comment to help me in understanding. By the way, I don't have compilation troubles on my system.
jcarpent
approved these changes
May 25, 2021
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As reported by @nmansard, including registration.hpp raise the following compilation issue:
Here is a regression test, the CI should fail.