Fix warnings to address unstable build on buildfarm #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should never be triggered.
between shared_ptr& and shared_ptr
for more information, see https://pre-commit.ci
jorisv
force-pushed
the
topic/fix-warnings
branch
from
8aa2687 to
ba86d54
Compare
jorisv
previously approved these changes
May 29, 2024
jorisv
force-pushed
the
topic/fix-warnings
branch
from
cd902db to
f50a0e5
Compare
jorisv
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having issues with the new pre-commit config (it fails on MacOS Python2 venv config - on Linux) so formatting may not be applied yet. Hoping for pre-commit CI to correct me :-)