Skip to content

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Oct 13, 2025

Description

Part of stackabletech/issues#747
This PR adds Prometheus annotations and adds a pod port for metrics

airflow_target_health

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 self-requested a review October 13, 2025 11:17
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 13, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander added this pull request to the merge queue Oct 13, 2025
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Oct 13, 2025
Merged via the queue into main with commit 3fadda1 Oct 13, 2025
31 of 32 checks passed
@maltesander maltesander deleted the chore/ensure-metrics-correctly-exposed branch October 13, 2025 14:29
@lfrancke
Copy link
Member

Please add a release note snippet. This could be considered a bug or a new feature. So you can use the form "Previously, this went wrong. With this release, this was fixed in the following way." but you don't have to.

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Oct 14, 2025
@maltesander
Copy link
Member Author

Release snippet:

Previously, the airflow-operator did not expose Prometheus annotations containing the http(s) scheme or the metrics path and port. This was added in this PR and allows custom relabel configs in Prometheus using these annotations.

@lfrancke lfrancke added release-note Denotes a PR that will be considered when it comes time to generate release notes. release/25.11.0 labels Nov 4, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/25.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Development

Successfully merging this pull request may close these issues.

4 participants