Skip to content

Consolidate ResultsBackend and Broker to clusterConfig#786

Merged
maltesander merged 10 commits intomainfrom
fix/consolidate-results-backend-broker-crd
May 6, 2026
Merged

Consolidate ResultsBackend and Broker to clusterConfig#786
maltesander merged 10 commits intomainfrom
fix/consolidate-results-backend-broker-crd

Conversation

@maltesander
Copy link
Copy Markdown
Member

@maltesander maltesander commented May 6, 2026

Description

based on decision https://github.com/stackabletech/decisions/issues/86

Now aligned with stackabletech/superset-operator#724

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added updated
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander self-assigned this May 6, 2026
@maltesander maltesander added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. labels May 6, 2026
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering May 6, 2026
@adwk67 adwk67 self-requested a review May 6, 2026 11:55
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 6, 2026
Copy link
Copy Markdown
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment about validation/warning

Comment thread rust/operator-binary/src/airflow_controller.rs Outdated
Copy link
Copy Markdown
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adwk67
Copy link
Copy Markdown
Member

adwk67 commented May 6, 2026

Openshift tests: 🟠 : https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/96/
(tests were fine; problems with NS termination)

@maltesander maltesander added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 9fcc743 May 6, 2026
12 checks passed
@maltesander maltesander deleted the fix/consolidate-results-backend-broker-crd branch May 6, 2026 15:21
@maltesander
Copy link
Copy Markdown
Member Author

Release Notes

Breaking:

  • Renamed and moved the celeryExecutor broker and results backend to clusterConfig.
    • The results backend spec.celeryExecutors.resultBackend is now located at spec.clusterConfig.celeryResultsBackend.
    • The broker spec.celeryExecutors.broker is now located at spec.clusterConfig.celeryBroker.

Docs

https://docs.stackable.tech/home/nightly/airflow/getting_started/first_steps/#_airflow

@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants