Conversation
maltesander
reviewed
Apr 8, 2022
Member
maltesander
left a comment
There was a problem hiding this comment.
Just some comments. Probably @teozkr needs to have another look :)
nightkr
approved these changes
Apr 13, 2022
Contributor
nightkr
left a comment
There was a problem hiding this comment.
LGTM for now, there's some documentation missing and generalization that we might want to do, but that's more of a problem that I need to get back to myself...
Member
Author
|
Thanks! Actually I intended to write some docs after this is merged. But for the generalization i think you're the best man! |
Member
|
Do we have a ticket for the documentation @sbernauer? If not, could you create one? |
Member
Author
|
There is no dedicated ticket for docs but the docs are tracked as part of stackabletech/issues#200 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For stackabletech/issues#200
Actual implementation copied from https://github.com/stackabletech/restart-controller
Integration-Test: https://github.com/stackabletech/integration-tests/pull/207
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information