Skip to content

Adopt to move of commons structs to operators-rs#18

Merged
sbernauer merged 2 commits intomainfrom
move-common-structs-to-operators-rs
Apr 19, 2022
Merged

Adopt to move of commons structs to operators-rs#18
sbernauer merged 2 commits intomainfrom
move-common-structs-to-operators-rs

Conversation

@sbernauer
Copy link
Copy Markdown
Member

Description

Follow up of stackabletech/operator-rs#366
The commons structs now reside in operator-rs

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer requested a review from a team April 14, 2022 06:30
@sbernauer sbernauer force-pushed the move-common-structs-to-operators-rs branch from 5dd7bf1 to 4a4ecd5 Compare April 19, 2022 06:33
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we can add a changelog ;)?

@sbernauer
Copy link
Copy Markdown
Member Author

Changelog added

@sbernauer
Copy link
Copy Markdown
Member Author

bors r+

bors Bot pushed a commit that referenced this pull request Apr 19, 2022
## Description

Follow up of stackabletech/operator-rs#366
The commons structs now reside in operator-rs
@bors
Copy link
Copy Markdown

bors Bot commented Apr 19, 2022

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@sbernauer sbernauer merged commit 0243fdd into main Apr 19, 2022
@bors bors Bot deleted the move-common-structs-to-operators-rs branch April 19, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants