Skip to content

fix: Respect --watch-namespace CLI argument#193

Merged
sbernauer merged 3 commits intomainfrom
fix/watch-namespace
Jan 10, 2024
Merged

fix: Respect --watch-namespace CLI argument#193
sbernauer merged 3 commits intomainfrom
fix/watch-namespace

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Dec 27, 2023

Description

Currently we ignore the CLI argument.
I think this is especially important for commons-op, as it consumes the most memory of all our operators.
If we don't merge this for any reasons we should remove the --watch-namespace CLI argument.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Copy link
Copy Markdown
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd also like to get to the bottom of the memory issue at some point...

@sbernauer
Copy link
Copy Markdown
Member Author

Yep, agreed

@sbernauer sbernauer added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit acd25ea Jan 10, 2024
@lfrancke lfrancke deleted the fix/watch-namespace branch May 7, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants