-
Notifications
You must be signed in to change notification settings - Fork 2
chore: Reduce severity of Pod eviction errors #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor thing (we should align to Semantic Conventions as much as possible.
https://opentelemetry.io/docs/specs/semconv/registry/attributes/k8s/#k8s-pod-name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the suggestion based on the earlier comments
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Release notesReduce severity of Pod eviction errors. Previously, the operator would produce lot's of |
Description
https://stackable-workspace.slack.com/archives/C08GM6S8Z8D/p1755112180910679
Tested by spinning up an ZookeeperCluster with 21 nodes and setting the expiration annotation of all of them at once to the past.
With this PR no error messages, only INFOs
2025-08-19T07:53:19.458655Z INFO stackable_commons_operator::restart_controller::pod: Tried to evict Pod, but wasn't allowed to do so, as it would violate the Pod's disruption budget. Retrying later pod=Pod.v1./simple-zk-server-default-17.default error=ApiError: Cannot evict pod as it would violate the pod's disruption budget.: TooManyRequests (ErrorResponse { status: "Failure", message: "Cannot evict pod as it would violate the pod's disruption budget.", reason: "TooManyRequests", code: 429 })Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker