fix: Remove null values from enums #30
Merged
+90
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfrancke
requested changes
Dec 9, 2025
Member
lfrancke
left a comment
lfrancke
left a comment
There was a problem hiding this comment.
Ran tests, looked at code, generated the site. Looks good to me with one minor nitpick left
Co-authored-by: Lars Francke <lars.francke@stackable.tech>
siegfriedweber
moved this from Development: Waiting for Review
to Development: Done
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
nullvalues from enumskube-rs 2.0.1 appends a
nullto all enums. These enums cannot be processed by this module. In stackabletech/kube-rs#1, the enum generation was fixed, but SDP 25.11 was released without this fix. Therefore, this change removes thenullvalues from the CRDs, so that the CRD documentation for SDP 25.11 can be rendered.