refactor(testing-tools): split into multiple images, switch to UBI, remove unnecessary components #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, remove unnecessary components
dervoeti
force-pushed
the
feat/testing-tools-multiple-images
branch
from
72fd454 to
6735ec2
Compare
dervoeti
changed the title
dervoeti
force-pushed
the
feat/testing-tools-multiple-images
branch
from
282d8d6 to
7359d29
Compare
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the decision in stackabletech/issues#767, this PR splits the testing tools into multiple sub images.
There now is a base testing-tools image and specialized images for Trino, Hive and NiFi. Also, Keycloak and Java were removed, since I could not find any evidence of them being used anywhere.
I ran the smoke-latest tests for Hive, Trino, NiFi and OPA plus the kerberos-hdfs test with Hive 4.0.1. Every test run used the new image (or the according sub image accordingly), all tests succeeded.
This PR also bumps the version from 0.2.0 to 0.3.0 so existing tests and demos won't break. We can bump them one by one and see if they still work (my initial tests worked fine, as mentioned before). If anything breaks we can adapt the testing-tools image.
The testing-tools image now has 366MB instead of the 1.25GB it had before. The sub image for Trino/Hive/NiFi also are around 400MB in size.
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
boilto retrieve the image manifest URI for<MANIFEST_URI>.