Conversation
nightkr
commented
Feb 6, 2023
Contributor
Author
|
The Hadolint DL3006 warnings are false positives, the |
razvan
previously approved these changes
Feb 7, 2023
Member
razvan
left a comment
razvan
left a comment
There was a problem hiding this comment.
Nice and elegant. Added some suggestions.
razvan
approved these changes
Feb 8, 2023
2 tasks
46 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the build workflow to generate a Bakefile (https://docs.docker.com/build/bake/), which is then passed to a single
docker buildxcall. This allows us to refer to other Dockerfiles in the tree directly, rather than having to build every step in the dependency chain manually, updating all the image references in between.Additionally, this lets Docker build and push multiple the whole tree in parallel, rather than building the images one by one.
Currently Airflow and Zookeeper (and their dependencies) have been updated to take advantage of local dependencies. Other images may not work without updating to theAll images have now been updated.docker/dockerfile:1syntax.