Skip to content

Rework Airflow images#431

Merged
lfrancke merged 8 commits intomainfrom
airflow-rework
Aug 1, 2023
Merged

Rework Airflow images#431
lfrancke merged 8 commits intomainfrom
airflow-rework

Conversation

@lfrancke
Copy link
Copy Markdown
Member

Description

This brings the Airflow Dockerfile in line with the latest changes for Hadoop and applies some lessons we learned and adds some new comments.

In particular:

  • Moves git_sync, tini and statsd_exporter versions to variables
  • Gets everything from our own repository
  • Syncs entrypoint.sh from airflow upstream

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [x] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there

@lfrancke lfrancke requested a review from a team July 31, 2023 20:11
@lfrancke lfrancke self-assigned this Jul 31, 2023
Comment thread airflow/stackable/utils/entrypoint.sh
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Comment thread airflow/Dockerfile
Comment thread hadoop/CHANGELOG.md Outdated
@lfrancke lfrancke requested a review from sbernauer August 1, 2023 06:52
sbernauer
sbernauer previously approved these changes Aug 1, 2023
Comment thread airflow/CHANGELOG.md Outdated
Comment thread airflow/CHANGELOG.md Outdated
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@lfrancke lfrancke requested a review from sbernauer August 1, 2023 07:00
@lfrancke lfrancke added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit 2f03ac3 Aug 1, 2023
@lfrancke lfrancke deleted the airflow-rework branch August 1, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants