Skip to content

Extract image-tools to it's own repository.#437

Merged
razvan merged 7 commits intomainfrom
feat/image-tools
Aug 30, 2023
Merged

Extract image-tools to it's own repository.#437
razvan merged 7 commits intomainfrom
feat/image-tools

Conversation

@razvan
Copy link
Copy Markdown
Member

@razvan razvan commented Aug 23, 2023

Description

Moved the image_tools module to it's own repository: https://github.com/stackabletech/image-tools

The image_tools/conf.py has been moved to the root of the repository and remains unchanged.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [x] Changes are OpenShift compatible
- [x] All added packages (via microdnf or otherwise) have a comment on why they are added
- [x] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [x] All packages should have (if available) signatures/hashes verified
- [x] Does your change affect an SBOM? Make sure to update all SBOMs

@razvan razvan requested a review from a team August 23, 2023 15:28
@razvan razvan self-assigned this Aug 23, 2023
@nightkr
Copy link
Copy Markdown
Contributor

nightkr commented Aug 23, 2023

Is there a discussion or rationale for this somewhere?

@razvan
Copy link
Copy Markdown
Member Author

razvan commented Aug 23, 2023

I guess, the rationale is that it's good to decouple tools from configuration. We can apply best practices to the Python code without polluting this repo with python specific project workflows.

@siegfriedweber siegfriedweber requested review from siegfriedweber and removed request for a team August 30, 2023 08:47
siegfriedweber
siegfriedweber previously approved these changes Aug 30, 2023
Copy link
Copy Markdown
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit 85ad3b5 Aug 30, 2023
@razvan razvan deleted the feat/image-tools branch August 30, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants