Skip to content

Add Omid 1.1.0 image#493

Merged
nightkr merged 15 commits intomainfrom
feature/omid
Dec 20, 2023
Merged

Add Omid 1.1.0 image#493
nightkr merged 15 commits intomainfrom
feature/omid

Conversation

@nightkr
Copy link
Copy Markdown
Contributor

@nightkr nightkr commented Oct 31, 2023 •
edited
Loading

Description

Fixes #492.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Does your change affect an SBOM? Make sure to update all SBOMs

github-actions[bot]
github-actions Bot reviewed Oct 31, 2023
View reviewed changes
Comment thread shared/log4shell.sh Outdated
@nightkr nightkr marked this pull request as ready for review December 1, 2023 15:49
@nightkr
Copy link
Copy Markdown
Contributor Author

nightkr commented Dec 1, 2023

Builds and seems to bind something, but an actual Omid expert will have to tell whether it's doing the right thing...

@nightkr nightkr requested a review from soenkeliebau December 1, 2023 15:51
lfrancke
lfrancke previously requested changes Dec 1, 2023
View reviewed changes
Comment thread omid/Dockerfile Outdated
Comment thread omid/Dockerfile Outdated
Comment thread omid/Dockerfile Outdated
Comment thread omid/Dockerfile Outdated
Comment thread omid/Dockerfile Outdated
Comment thread omid/Dockerfile Outdated
@nightkr nightkr requested a review from lfrancke December 4, 2023 09:33
@adwk67 adwk67 self-requested a review December 11, 2023 10:05
adwk67
adwk67 requested changes Dec 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@adwk67 adwk67 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully tested this with the hbase/hdfs cycling-demo and a deployment for the omid image, together with the basic/snapshot-isolation/parallel example packages. Just had to make the two changes shown here. I'll document this in Nuclino.

Comment thread omid/Dockerfile
Comment thread omid/Dockerfile Outdated
@nightkr @adwk67
Update omid/Dockerfile
7c721be 
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
adwk67
adwk67 previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@nightkr nightkr enabled auto-merge December 13, 2023 09:01
@nightkr
Copy link
Copy Markdown
Contributor Author

nightkr commented Dec 13, 2023

@lfrancke we're still blocked on your review :P

@nightkr nightkr added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit 11fdfa1 Dec 20, 2023
@nightkr nightkr deleted the feature/omid branch December 20, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@adwk67 adwk67 adwk67 approved these changes

@soenkeliebau soenkeliebau Awaiting requested review from soenkeliebau

@lfrancke lfrancke Awaiting requested review from lfrancke

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Apache Omid image

3 participants

@nightkr @lfrancke @adwk67