Skip to content

Fix path substitution in the hbck2 script#498

Merged
siegfriedweber merged 1 commit intomainfrom
bugfix/hbck2
Nov 9, 2023
Merged

Fix path substitution in the hbck2 script#498
siegfriedweber merged 1 commit intomainfrom
bugfix/hbck2

Conversation

@siegfriedweber
Copy link
Copy Markdown
Member

Description

The ShellCheck comment turned the whole RUN argument into a comment and the paths in the hbck2 script were not substituted. This was the reason why no ShellCheck warning was emitted. Disabling the ShellCheck warning does not work in a Dockerfile, because there can be no separate line in the command which disables the ShellCheck, and inline comments with `# ...` and $(: ...) are not recognized by ShellCheck.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [x] Changes are OpenShift compatible
- [x] All added packages (via microdnf or otherwise) have a comment on why they are added
- [x] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [x] All packages should have (if available) signatures/hashes verified
- [x] Does your change affect an SBOM? Make sure to update all SBOMs

@siegfriedweber siegfriedweber requested a review from a team November 9, 2023 11:25
@siegfriedweber siegfriedweber self-assigned this Nov 9, 2023
@siegfriedweber siegfriedweber added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 5823cf9 Nov 9, 2023
@siegfriedweber siegfriedweber deleted the bugfix/hbck2 branch November 9, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants