Skip to content

fix: add tzdata to superset image#499

Merged
adwk67 merged 3 commits intomainfrom
fix/add-tzdata-for-superset
Nov 9, 2023
Merged

fix: add tzdata to superset image#499
adwk67 merged 3 commits intomainfrom
fix/add-tzdata-for-superset

Conversation

@adwk67
Copy link
Copy Markdown
Member

@adwk67 adwk67 commented Nov 9, 2023

Description

  • Redhat has removed tzdata from the ubi-minimal images. See here and here.
  • Superset relies on ZoneInfo to resolve time zones, and this is done by searching first under TZPATH (which is empty due to the point above) or for the tzdata python package.
  • That package is added in this PR (airflow already has tzdata in its list of dependencies).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [x] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Does your change affect an SBOM? Make sure to update all SBOMs

@adwk67 adwk67 marked this pull request as ready for review November 9, 2023 16:27
@adwk67 adwk67 requested a review from a team November 9, 2023 16:27
@adwk67 adwk67 self-assigned this Nov 9, 2023
@sbernauer
Copy link
Copy Markdown
Member

Thanks for the catch and the nice description!
Could you please add the description as comment above the package, so that we keep this valuable information?

@adwk67
Copy link
Copy Markdown
Member Author

adwk67 commented Nov 9, 2023

Thanks for the catch and the nice description! Could you please add the description as comment above the package, so that we keep this valuable information?

Done!

Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 004d8d2 Nov 9, 2023
@adwk67 adwk67 deleted the fix/add-tzdata-for-superset branch November 9, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants