Merged
Conversation
Member
Author
|
https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/111/ All tests but one succeeded. The reason for the failed test is described in stackabletech/hdfs-operator#443. |
lfrancke
approved these changes
Dec 21, 2023
Member
lfrancke
left a comment
There was a problem hiding this comment.
Thank you!
I looked at it and it looks good.
I'm a bit surprised by the different protobuf versions as I thought I already looked at that but I must have made a mistake, thanks for catching that.
I built the image locally and the build worked. I have not tested it though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Build Hadoop from source
Closes #525
Definition of Done Checklist