Skip to content

Updating dockerfiles and base images for ARM support#534

Merged
Maleware merged 49 commits intomainfrom
fix/multi-arch-base-images
Feb 9, 2024
Merged

Updating dockerfiles and base images for ARM support#534
Maleware merged 49 commits intomainfrom
fix/multi-arch-base-images

Conversation

@Maleware
Copy link
Copy Markdown
Member

@Maleware Maleware commented Jan 23, 2024

Description

part of: stackabletech/issues#475

This PR is cherrypicking from #527

As we won't downgrade dependencies from airflow and superset ( compiling problems ), this only picks the following.

Airflow

Dockerfile update for statsd_exporter as multi-arch binary

Superset

Same as Airflow

Opa

Same as airflow

Base-Images

Rust-Builder and stackable-base got a multi-arch list of ubi-8 8.9

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Does your change affect an SBOM? Make sure to update all SBOMs

@Maleware Maleware self-assigned this Jan 23, 2024
@sbernauer sbernauer self-requested a review January 23, 2024 10:44
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, as this should not introduce any (significant) changes to x86 images

Comment thread CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Only minor things.
And could you maybe add a script to upload a new statsd exporter to nexus (similar to the ones we already have)?

Comment thread airflow/Dockerfile Outdated
Comment thread stackable-base/Dockerfile Outdated
Comment thread superset/Dockerfile
Comment thread superset/Dockerfile Outdated
Comment thread ubi8-rust-builder/Dockerfile Outdated
Comment thread airflow/Dockerfile Outdated
Copy link
Copy Markdown
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

Comment thread airflow/Dockerfile Outdated
Comment thread airflow/Dockerfile Outdated
Comment thread airflow/Dockerfile
Comment thread superset/Dockerfile Outdated
Comment thread superset/Dockerfile Outdated
@Maleware Maleware requested a review from lfrancke February 2, 2024 11:46
@lfrancke
Copy link
Copy Markdown
Member

lfrancke commented Feb 2, 2024

Looking good but let's wait for the discussion around #540

@fhennig fhennig changed the title Updating dockerfiles and base images Updating dockerfiles and base images for ARM support Feb 5, 2024
Comment thread kafka/Dockerfile Outdated
Comment thread upload_new_tini_version.sh
Comment thread conf.py
Comment thread opa/Dockerfile Outdated
Comment thread superset/Dockerfile Outdated
siegfriedweber
siegfriedweber previously approved these changes Feb 9, 2024
Copy link
Copy Markdown
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread CHANGELOG.md Outdated
Spellcheck bernauer

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@Maleware Maleware enabled auto-merge February 9, 2024 13:41
@Maleware Maleware dismissed lfrancke’s stale review February 9, 2024 13:45

Is in, just not the way GH likes it

@Maleware Maleware added this pull request to the merge queue Feb 9, 2024
Merged via the queue into main with commit bd13701 Feb 9, 2024
@Maleware Maleware deleted the fix/multi-arch-base-images branch February 9, 2024 13:46
@lfrancke
Copy link
Copy Markdown
Member

This is nothing user-visible yet, correct?
This is "only" foundation work?

@Maleware
Copy link
Copy Markdown
Member Author

Yes, customer visible is only 23.11.0 in stackable-experimental . We are going to release a short article on how to access it and what to expect from it stackabletech/documentation#527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants