Skip to content

Add pytest to testing tools#575

Merged
maltesander merged 3 commits intomainfrom
add-pytest-to-testingtools
Feb 22, 2024
Merged

Add pytest to testing tools#575
maltesander merged 3 commits intomainfrom
add-pytest-to-testingtools

Conversation

@maltesander
Copy link
Copy Markdown
Member

Description

Please add a description here.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Does your change affect an SBOM? Make sure to update all SBOMs

@maltesander maltesander requested a review from a team February 22, 2024 12:39
@maltesander maltesander self-assigned this Feb 22, 2024
sbernauer
sbernauer previously approved these changes Feb 22, 2024
Comment thread testing-tools/python/requirements.txt Outdated
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan
Copy link
Copy Markdown
Member

razvan commented Feb 22, 2024

Just out of curiosity: what is this needed for ? Isn't the built in unittest module enough?

@sbernauer
Copy link
Copy Markdown
Member

Isn't the built in unittest module enough?

Is this a thing? 😂 I guess this counts as an answer

@maltesander
Copy link
Copy Markdown
Member Author

Good question next question :D

@sbernauer
Copy link
Copy Markdown
Member

Chief Python developer has spoken 🙏

@maltesander
Copy link
Copy Markdown
Member Author

I added it because its required in a test script and i wanted to get the test pipeline working, not really thought about it.
Since its just for internal testing, whats against that @razvan ?

@razvan
Copy link
Copy Markdown
Member

razvan commented Feb 22, 2024

I added it because its required in a test script and i wanted to get the test pipeline working, not really thought about it. Since its just for internal testing, whats against that @razvan ?

Pytest is great. I was just wondering if we need something that unittest can't already do.

So, go ahead.

@maltesander maltesander added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit bc0d2bd Feb 22, 2024
@maltesander maltesander deleted the add-pytest-to-testingtools branch February 22, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants