Skip to content

Release multi-arch images#616

Merged
sbernauer merged 4 commits intomainfrom
feat/release-multi-arch
Apr 16, 2024
Merged

Release multi-arch images#616
sbernauer merged 4 commits intomainfrom
feat/release-multi-arch

Conversation

@sbernauer
Copy link
Copy Markdown
Member

Description

Not tested yet. Given this is mostly copy/past we could argue it's not worth it pointing it to stackable-experimental, running it with a bogus version, clean up all the images again and revert the bogus change.
Additionally, currently the build is broken because of building Hive from source missing packages on ARM (https://issues.apache.org/jira/browse/HIVE-21939)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Does your change affect an SBOM? Make sure to update all SBOMs
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

Copy link
Copy Markdown
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry. Other than that, awesome! :)

Maleware
Maleware previously approved these changes Apr 11, 2024
Copy link
Copy Markdown
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM ;)

@sbernauer sbernauer added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit dca69c4 Apr 16, 2024
@sbernauer sbernauer deleted the feat/release-multi-arch branch April 16, 2024 12:20
@lfrancke
Copy link
Copy Markdown
Member

Did we update the documentation for this? Can you link it here please.

@sbernauer
Copy link
Copy Markdown
Member Author

I'm not aware of any documentation but maybe @Maleware knows better. We only worked on the build process, for the customer nothing should change (it's just that docker manifest now supports multi-arch).
Starting with 24.7 it "just works" (tm) on ARM, I wouldn't know what to document

@maltesander
Copy link
Copy Markdown
Member

We mentioned it in the release docs (https://docs.stackable.tech/home/stable/release-notes.html) and point to experimental docs here https://docs.stackable.tech/home/stable/concepts/arm64-support @lfrancke

@sbernauer
Copy link
Copy Markdown
Member Author

@maltesander just FYI this work here enables us to get rid of https://docs.stackable.tech/home/stable/concepts/arm64-support.
This is the proper solution to include it in the SDP, no special repo, opt in or anything else is needed in 24.7. any more 🚀

@Maleware
Copy link
Copy Markdown
Member

Yeah we didn't document consumer facing as this is going to be abstracted away by the method we use. As Malte said, we give instructions on how to early access this feature and as Sebastian mentioned, the customer won't need to do anything anymore past 24.7.

@lfrancke
Copy link
Copy Markdown
Member

Thank you. Did we then delete the experimental page?
And we should definitely document somewhere the supported platforms.
x86 is kinda given but we should have some way to document that we also support ARM.

Do we have this?
If not I'd like to see a follow-up ticket

@Maleware
Copy link
Copy Markdown
Member

Maleware commented May 2, 2024

Great Idea, no we didn't deprecate any documentation till as we are not ready.

I like the idea of having supported architectures listed somewhere I created an issue in the arm64 epic

@lfrancke
Copy link
Copy Markdown
Member

lfrancke commented May 6, 2024

I am a bit confused still

This is the proper solution to include it in the SDP, no special repo, opt in or anything else is needed in 24.7. any more 🚀

Great Idea, no we didn't deprecate any documentation till as we are not ready.

Anyway: I have added a task to stackabletech/issues#577 to remove the old stuff as well.

@sbernauer
Copy link
Copy Markdown
Member Author

Did we then delete the experimental page?

We can not delete the only docs on arm support (which is based on 24.3), simply because 24.7 is not released yet.
One we released 24.7 we can remove the intermediate docs (based on 24.3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants