Skip to content

chore: pass linux arch to check-container#626

Merged
adwk67 merged 4 commits intomainfrom
chore/use-arch-for-preflight
Apr 25, 2024
Merged

chore: pass linux arch to check-container#626
adwk67 merged 4 commits intomainfrom
chore/use-arch-for-preflight

Conversation

@adwk67
Copy link
Copy Markdown
Member

@adwk67 adwk67 commented Apr 25, 2024

Description

Part of stackabletech/issues#559.
chore: pass linux arch to check-container so that the correct image can be pulled when using manifest lists.

Tested with:
gh workflow run --ref chore/use-arch-for-preflight preflight.yaml
https://github.com/stackabletech/docker-images/actions/runs/8829927993

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [x] Changes are OpenShift compatible
- [x] Add an entry to the CHANGELOG.md file
- [x] ~Integration tests~ github action ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@adwk67 adwk67 marked this pull request as ready for review April 25, 2024 09:59
@adwk67 adwk67 self-assigned this Apr 25, 2024
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@adwk67 adwk67 added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 5048bbf Apr 25, 2024
@adwk67 adwk67 deleted the chore/use-arch-for-preflight branch April 25, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants