Patch NiFi assembly to not zip binaries to save disk space#685
Merged
maltesander merged 2 commits intomainfrom May 17, 2024
Merged
Patch NiFi assembly to not zip binaries to save disk space#685maltesander merged 2 commits intomainfrom
maltesander merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For NiFi version 1.21.0 and 1.23.2 the github runners do not have enough space and fail to build these images:
The nifi-assembly zips the resulting binaries which adds another ~1.3 GB but are not used in the main image since the unzipped binaries are copied over.
This PR patches the pom file to not zip the binaries in the end to save disk space.
Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.