Skip to content

feat: Add log processing script to opa for decision logging#695

Merged
xeniape merged 13 commits intomainfrom
feat-processing-log-messages
Jun 3, 2024
Merged

feat: Add log processing script to opa for decision logging#695
xeniape merged 13 commits intomainfrom
feat-processing-log-messages

Conversation

@xeniape
Copy link
Copy Markdown
Member

@xeniape xeniape commented May 27, 2024

Description

Part of stackabletech/opa-operator#422

This PR adds the script which is used in the opa start command set by the opa-operator to filter incoming logs by log level and route logs to the correct output (file or console).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [x] Changes are OpenShift compatible
- [x] All added packages (via microdnf or otherwise) have a comment on why they are added
- [x] Add an entry to the CHANGELOG.md file
- [x] Integration tests ran successfully https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/96/
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice script. If you haven't already, it might pay to run it through the shellcheck linter.

Comment thread opa/stackable/bin/process-logs
Comment thread opa/stackable/bin/process-logs Outdated
sbernauer
sbernauer previously approved these changes May 27, 2024
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, exactly what I was thinking of! Haven't properly reviewed the operator part yet, feel free to wait with merge until both are ready to be merged.
Also happy about @siegfriedweber's review

Comment thread opa/stackable/bin/process-logs Outdated
Comment thread opa/stackable/bin/process-logs Outdated
Comment thread opa/stackable/bin/process-logs Outdated
@siegfriedweber siegfriedweber self-requested a review May 27, 2024 11:36
Comment thread opa/stackable/bin/process-logs Outdated
Comment thread opa/stackable/bin/process-logs Outdated
@xeniape xeniape requested a review from siegfriedweber May 29, 2024 10:07
Copy link
Copy Markdown
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeniape xeniape added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 03ff53b Jun 3, 2024
@xeniape xeniape deleted the feat-processing-log-messages branch June 3, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants