Skip to content

Suggested changes for ARM docs#558

Merged
lfrancke merged 9 commits intomainfrom
arm-docs
Mar 6, 2024
Merged

Suggested changes for ARM docs#558
lfrancke merged 9 commits intomainfrom
arm-docs

Conversation

@lfrancke
Copy link
Copy Markdown
Member

No description provided.

@lfrancke lfrancke requested a review from Maleware February 27, 2024 15:37
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 27, 2024

Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit 27cc203
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/65e892943dcd230008d8f436
😎 Deploy Preview https://deploy-preview-558--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed your comments from #527

Thanks for your effort :)

Comment thread modules/concepts/pages/arm64-support.adoc Outdated
Comment thread modules/concepts/pages/arm64-support.adoc Outdated
Comment thread modules/concepts/pages/arm64-support.adoc Outdated
Comment thread modules/concepts/pages/arm64-support.adoc Outdated
Comment thread modules/concepts/pages/arm64-support.adoc Outdated
Comment thread modules/concepts/pages/arm64-support.adoc Outdated
lfrancke and others added 6 commits February 29, 2024 09:24
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
# Conflicts:
#	modules/concepts/pages/arm64-support.adoc
@Maleware
Copy link
Copy Markdown
Member

Maleware commented Mar 4, 2024

Thanks for your work Lars. You can omit my comments and resolve conversations!

Maleware
Maleware previously approved these changes Mar 4, 2024
Copy link
Copy Markdown
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your rework, appreciated.

Comment thread modules/concepts/pages/arm64-support.adoc
Comment thread modules/concepts/pages/arm64-support.adoc
Copy link
Copy Markdown
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lfrancke lfrancke enabled auto-merge March 6, 2024 15:58
@lfrancke lfrancke added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 03ca5ea Mar 6, 2024
@lfrancke lfrancke deleted the arm-docs branch March 6, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants