Conversation
razvan
reviewed
Feb 4, 2022
deploy/manifests/crds.yaml
Outdated
| - routers | ||
| - version | ||
| - zookeeperReference | ||
| - zookeeperCluster |
Member
There was a problem hiding this comment.
Other operators (kafka, hdfs) seem to have standardized on zookeeperConfigMapName for this because it could refer to either a ZNode or a Zookeeper cluster.
Contributor
Author
There was a problem hiding this comment.
It's not a very good name I believe but I'll change it for consistency
razvan
approved these changes
Feb 7, 2022
Member
razvan
left a comment
razvan
left a comment
There was a problem hiding this comment.
Successfully tested locally with integration tests.
Contributor
Author
|
great thank you! |
Contributor
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2022
## Description This PR removes the `namespace` field for the zookeeper reference; i.e. it is now not required to specify a namespace, instead the operator looks for the discovery config map in the same namespace as the druid cluster is. This is the intended behaviour and also necessary for the kuttl tests to work. ## Review Checklist - [x] Code contains useful comments - [x] (Integration-)Test cases added (or not applicable) - [x] Documentation added (or not applicable) - [x] Changelog updated (or not applicable) - [x] Cargo.toml only contains references to git tags (not specific commits or branches) - [x] Helm chart can be installed and deployed operator works (or not applicable) Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests) Co-authored-by: Stacky McStackface <stackable-bot@users.noreply.github.com>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
namespacefield for the zookeeper reference; i.e. it is now not required to specify a namespace, instead the operator looks for the discovery config map in the same namespace as the druid cluster is.This is the intended behaviour and also necessary for the kuttl tests to work.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information