Skip to content

[Merged by Bors] - Support specifying a namespace to watch#183

Closed
maltesander wants to merge 6 commits intomainfrom
feature/watch_single_namespace
Closed

[Merged by Bors] - Support specifying a namespace to watch#183
maltesander wants to merge 6 commits intomainfrom
feature/watch_single_namespace

Conversation

@maltesander
Copy link
Copy Markdown
Member

@maltesander maltesander commented Feb 24, 2022 •
edited by razvan
Loading

Description

try

cargo run -- run --watch-namespace test

or

export WATCH_NAMESPACE=test
cargo run -- run

fixes #173

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team February 24, 2022 14:08
@maltesander maltesander marked this pull request as ready for review February 24, 2022 14:10
razvan
razvan approved these changes Feb 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

razvan
razvan approved these changes Feb 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maltesander
Copy link
Copy Markdown
Member Author

maltesander commented Feb 28, 2022

bors merge

bors bot pushed a commit that referenced this pull request Feb 28, 2022
@maltesander @razvan
Support specifying a namespace to watch (#183)
b62253a 
## Description

try
```
cargo run -- run --watch-namespace test
```
or
```
export WATCH_NAMESPACE=test
cargo run -- run
```

fixes #173



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Feb 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support specifying a namespace to watch [Merged by Bors] - Support specifying a namespace to watch Feb 28, 2022
@bors bors bot closed this Feb 28, 2022
@bors bors bot deleted the feature/watch_single_namespace branch February 28, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razvan razvan razvan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support specifying a namespace to watch

2 participants

@maltesander @razvan