Skip to content

[Merged by Bors] - Adapt Druid to new S3 structs#228

Closed
fhennig wants to merge 24 commits intomainfrom
s3-changes
Closed

[Merged by Bors] - Adapt Druid to new S3 structs#228
fhennig wants to merge 24 commits intomainfrom
s3-changes

Conversation

@fhennig
Copy link
Copy Markdown
Contributor

@fhennig fhennig commented May 5, 2022

Description

fixes #216

relevant integration test PR: https://github.com/stackabletech/integration-tests/pull/240

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@fhennig fhennig marked this pull request as ready for review May 23, 2022 12:17
@adwk67 adwk67 self-assigned this May 24, 2022
Copy link
Copy Markdown
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than one small typo, LGTM.

Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
@fhennig
Copy link
Copy Markdown
Contributor Author

fhennig commented May 24, 2022

bors merge

bors bot pushed a commit that referenced this pull request May 24, 2022
## Description

fixes #216 

relevant integration test PR: https://github.com/stackabletech/integration-tests/pull/240



Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented May 24, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Adapt Druid to new S3 structs [Merged by Bors] - Adapt Druid to new S3 structs May 24, 2022
@bors bors bot closed this May 24, 2022
@bors bors bot deleted the s3-changes branch May 24, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor S3 configuration to be compabitle with ADR and operator-rs implementation

2 participants