Skip to content

[Merged by Bors] - Support S3 TLS verification & Druid 0.23.0#255

Closed
sbernauer wants to merge 14 commits intomainfrom
support-s3-structs
Closed

[Merged by Bors] - Support S3 TLS verification & Druid 0.23.0#255
sbernauer wants to merge 14 commits intomainfrom
support-s3-structs

Conversation

@sbernauer
Copy link
Copy Markdown
Member

Description

For #252

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer marked this pull request as ready for review June 27, 2022 09:43
@sbernauer sbernauer force-pushed the support-s3-structs branch from 06ef28e to efc93a3 Compare June 27, 2022 09:44
@sbernauer sbernauer force-pushed the support-s3-structs branch from efc93a3 to 7bbdd1f Compare June 27, 2022 09:46
@sbernauer
Copy link
Copy Markdown
Member Author

@sbernauer sbernauer changed the title Add support for S3 TLS verification Support S3 TLS verification Jun 27, 2022
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbernauer sbernauer changed the title Support S3 TLS verification Support S3 TLS verification & Druid 0.23.0 Jun 27, 2022
Copy link
Copy Markdown
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbernauer
Copy link
Copy Markdown
Member Author

Thanks a lot all of you!

@sbernauer
Copy link
Copy Markdown
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 27, 2022
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Jun 27, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support S3 TLS verification & Druid 0.23.0 [Merged by Bors] - Support S3 TLS verification & Druid 0.23.0 Jun 27, 2022
@bors bors bot closed this Jun 27, 2022
@bors bors bot deleted the support-s3-structs branch June 27, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants