Skip to content

[Merged by Bors] - Run init container non root and remove chmod/chown#353

Closed
maltesander wants to merge 7 commits intomainfrom
run-init-container-non-root
Closed

[Merged by Bors] - Run init container non root and remove chmod/chown#353
maltesander wants to merge 7 commits intomainfrom
run-init-container-non-root

Conversation

@maltesander
Copy link
Copy Markdown
Member

@maltesander maltesander commented Dec 2, 2022 •
edited
Loading

Description

  • run init container as non root
  • added run as user and group (1000)
  • removed chown and chmods in init scripts
  • Adapted tests to new nightly product image selection of zk and hdfs operator

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/45/console

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander mentioned this pull request Dec 2, 2022
Closed
15 tasks
@maltesander maltesander requested a review from a team December 2, 2022 13:53
@maltesander maltesander self-assigned this Dec 2, 2022
@maltesander maltesander marked this pull request as ready for review December 2, 2022 13:53
sbernauer
sbernauer approved these changes Dec 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests passed

@maltesander @sbernauer
Update rust/operator-binary/src/druid_controller.rs
337cbe9 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@maltesander
Copy link
Copy Markdown
Member Author

maltesander commented Dec 2, 2022

bors merge

bors bot pushed a commit that referenced this pull request Dec 2, 2022
@maltesander
Run init container non root and remove chmod/chown (#353)
d35c61a 
# Description

- run init container as non root
- added run as user and group (1000)
- removed chown and chmods in init scripts
- Adapted tests to new nightly product image selection of zk and hdfs operator 

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/45/console



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Dec 2, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Run init container non root and remove chmod/chown [Merged by Bors] - Run init container non root and remove chmod/chown Dec 2, 2022
@bors bors bot closed this Dec 2, 2022
@bors bors bot deleted the run-init-container-non-root branch December 2, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maltesander @sbernauer