Skip to content

[Merged by Bors] - Refactor merging and validation of the configuration#404

Closed
siegfriedweber wants to merge 10 commits intomainfrom
fragment-config
Closed

[Merged by Bors] - Refactor merging and validation of the configuration#404
siegfriedweber wants to merge 10 commits intomainfrom
fragment-config

Conversation

@siegfriedweber
Copy link
Copy Markdown
Member

@siegfriedweber siegfriedweber commented Feb 22, 2023

Description

Merging and validation of the configuration refactored

Prerequisite for #364

Integration tests

Build Status

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Just really minor things not even from this PR :D sorry for that. LGTM otherwise.

Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@siegfriedweber
Copy link
Copy Markdown
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Feb 27, 2023
# Description

Merging and validation of the configuration refactored
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Feb 27, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Refactor merging and validation of the configuration [Merged by Bors] - Refactor merging and validation of the configuration Feb 27, 2023
@bors bors bot closed this Feb 27, 2023
@bors bors bot deleted the fragment-config branch February 27, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants