Closed
Conversation
Member
Author
Member
Author
Member
Author
|
Test succeeded, re-running after merging main |
vsupalov
suggested changes
Mar 2, 2023
Contributor
vsupalov
left a comment
There was a problem hiding this comment.
Looks great! I have nothing apart from small observations. I think the tradeoff "if we have ldap, we expect tls to be enabled" is reasonable, although the idealist in me complains. We can roll with it, it will probably not be an issue for any real usecase. (And for those who might complain, not having non-bind LDAP would be an issue as well probably.)
One part which is missing, is adjusting the LDAP docs over in the usage.adoc file. Once that is adjusted, we can merge this.
Member
Author
|
bors r+ |
Contributor
|
Pull request successfully merged into main. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #382
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information