Skip to content

[Merged by Bors] - Implement pause/stop#422

Closed
Maleware wants to merge 23 commits intomainfrom
implement-pause/stop
Closed

[Merged by Bors] - Implement pause/stop#422
Maleware wants to merge 23 commits intomainfrom
implement-pause/stop

Conversation

@Maleware
Copy link
Copy Markdown
Member

@Maleware Maleware commented Mar 31, 2023 •
edited by maltesander
Loading

Description

test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/102/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@Maleware
Copy link
Copy Markdown
Member Author

Maleware commented Mar 31, 2023

Still WIP !

@Maleware Maleware mentioned this pull request Mar 31, 2023
Closed
16 tasks
maltesander
maltesander reviewed Apr 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator-rs update missing in "Changed" changelog entry

maltesander
maltesander approved these changes Apr 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

bors bot pushed a commit that referenced this pull request Apr 5, 2023
@Maleware @maltesander
Implement pause/stop (#422)
ff63cb6 
# Description

test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/102/



Co-authored-by: Maximilian Wittich <56642549+Maleware@users.noreply.github.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Apr 5, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement pause/stop [Merged by Bors] - Implement pause/stop Apr 5, 2023
@bors bors bot closed this Apr 5, 2023
@bors bors bot deleted the implement-pause/stop branch April 5, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@Maleware Maleware

Labels

release/23.4.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Maleware @maltesander @lfrancke