Skip to content

[Merged by Bors] - feat: Set explicit resources on all containers#444

Closed
razvan wants to merge 14 commits intomainfrom
feat/resource-quotas
Closed

[Merged by Bors] - feat: Set explicit resources on all containers#444
razvan wants to merge 14 commits intomainfrom
feat/resource-quotas

Conversation

@razvan
Copy link
Copy Markdown
Member

@razvan razvan commented Jun 6, 2023 •
edited by lfrancke
Loading

Description

Part of: stackabletech/issues#394

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)

# Reviewer
- [x] Code contains useful comments
- [ ] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [x] Feature Tracker has been updated
- [x] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@razvan razvan mentioned this pull request Jun 6, 2023
Closed
@razvan razvan changed the title Smoke tests with resource quotas Set explicit resources on all containers Jun 27, 2023
@sbernauer sbernauer changed the title Set explicit resources on all containers feat: Set explicit resources on all containers Jun 28, 2023
@razvan razvan self-assigned this Jun 28, 2023
@razvan razvan marked this pull request as ready for review June 29, 2023 06:09
@razvan razvan requested a review from a team June 29, 2023 06:09
@sbernauer sbernauer self-assigned this Jun 29, 2023
sbernauer
sbernauer reviewed Jun 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things

sbernauer
sbernauer approved these changes Jun 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass

@razvan
Copy link
Copy Markdown
Member Author

razvan commented Jun 29, 2023

Latest tests pass

--- PASS: kuttl (2419.95s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/hdfs-deep-storage_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev (445.72s)
        --- PASS: kuttl/harness/logging_druid-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev (520.83s)
        --- PASS: kuttl/harness/resources_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev (198.70s)
        --- PASS: kuttl/harness/ldap-authentication_druid-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_opa-0.45.0-stackable0.0.0-dev_hadoop-latest-3.3.4-stackable0.0.0-dev_ldap-use-tls-true_ldap-no-bind-credentials-false_openshift-true (352.87s)
        --- PASS: kuttl/harness/s3-deep-storage_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_s3-use-tls-true (314.49s)
        --- PASS: kuttl/harness/ingestion-s3-ext_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev (396.33s)
        --- PASS: kuttl/harness/authorizer_druid-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_opa-0.45.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev (376.75s)
        --- PASS: kuttl/harness/cluster-operation_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_hadoop-latest-3.3.4-stackable0.0.0-dev (426.07s)
        --- PASS: kuttl/harness/tls_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_tls-mode-internal-and-server-tls-and-tls-client-auth_openshift-true (320.70s)
        --- PASS: kuttl/harness/orphans_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev (405.80s)
        --- PASS: kuttl/harness/smoke_druid-26.0.0-stackable0.0.0-dev_zookeeper-3.8.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev_openshift-true (347.24s)
        --- PASS: kuttl/harness/ingestion-no-s3-ext_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev (381.13s)

@razvan
Copy link
Copy Markdown
Member Author

razvan commented Jun 29, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jun 29, 2023
@razvan
feat: Set explicit resources on all containers (#444)
3887866 
# Description

Part of: stackabletech/issues#394
sbernauer
sbernauer requested changes Jun 29, 2023
View reviewed changes
@sbernauer
Copy link
Copy Markdown
Member

sbernauer commented Jun 29, 2023

bors cancel

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Jun 29, 2023

Canceled.

@sbernauer
Copy link
Copy Markdown
Member

sbernauer commented Jun 29, 2023

Sorry, missed that change

@razvan
Copy link
Copy Markdown
Member Author

razvan commented Jun 29, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jun 29, 2023
@razvan
feat: Set explicit resources on all containers (#444)
7b8fad2 
# Description

Part of: stackabletech/issues#394
@razvan
Copy link
Copy Markdown
Member Author

razvan commented Jun 29, 2023

bors cancel

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Jun 29, 2023

Canceled.

@razvan @sbernauer
Update docs/modules/druid/pages/usage-guide/resources-and-storage.adoc
6132936 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan
Copy link
Copy Markdown
Member Author

razvan commented Jun 29, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jun 29, 2023
@razvan
feat: Set explicit resources on all containers (#444)
c011419 
# Description

Part of: stackabletech/issues#394
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Jun 29, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Set explicit resources on all containers [Merged by Bors] - feat: Set explicit resources on all containers Jun 29, 2023
@bors bors bot closed this Jun 29, 2023
@bors bors bot deleted the feat/resource-quotas branch June 29, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@razvan razvan

@sbernauer sbernauer

Labels

release/23.7.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@razvan @sbernauer @lfrancke