Skip to content

[Merged by Bors] - feat: Support podOverrides#450

Closed
sbernauer wants to merge 5 commits intomainfrom
feat/pod-overrides
Closed

[Merged by Bors] - feat: Support podOverrides#450
sbernauer wants to merge 5 commits intomainfrom
feat/pod-overrides

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Jul 3, 2023

Description

Part of stackabletech/issues#346

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [x] Feature Tracker has been updated
- [x] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer
Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nitpicking!

@sbernauer
Copy link
Copy Markdown
Member Author

@maltesander please have a look at the new test

@sbernauer
Copy link
Copy Markdown
Member Author

@sbernauer
Copy link
Copy Markdown
Member Author

@maltesander
Copy link
Copy Markdown
Member

Looks good!

@sbernauer
Copy link
Copy Markdown
Member Author

bors r+
Resources test failed, fixed it and passed locally

bors bot pushed a commit that referenced this pull request Jul 5, 2023
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Jul 5, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Support podOverrides [Merged by Bors] - feat: Support podOverrides Jul 5, 2023
@bors bors bot closed this Jul 5, 2023
@sbernauer sbernauer self-assigned this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants