Skip to content

Let secret operator create pkcs12 stores#474

Merged
maltesander merged 3 commits intomainfrom
let-secret-op-create-pkcs12-stores
Sep 28, 2023
Merged

Let secret operator create pkcs12 stores#474
maltesander merged 3 commits intomainfrom
let-secret-op-create-pkcs12-stores

Conversation

@maltesander
Copy link
Copy Markdown
Member

@maltesander maltesander commented Sep 27, 2023 •
edited by sbernauer
Loading

Description

fixes #468

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [x] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@maltesander maltesander requested a review from a team September 27, 2023 10:36
@maltesander maltesander self-assigned this Sep 27, 2023
@maltesander
Copy link
Copy Markdown
Member Author

maltesander commented Sep 27, 2023

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/115/

sbernauer
sbernauer approved these changes Sep 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice comments!

@maltesander maltesander added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 52e828f Sep 28, 2023
@maltesander maltesander deleted the let-secret-op-create-pkcs12-stores branch September 28, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Let secret-operator handle PKCS#12 conversion

2 participants

@maltesander @sbernauer