Skip to content

feat: Support PodDisruptionBudgets#477

Merged
sbernauer merged 5 commits intomainfrom
feat/support-pdb
Oct 5, 2023
Merged

feat: Support PodDisruptionBudgets#477
sbernauer merged 5 commits intomainfrom
feat/support-pdb

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Oct 4, 2023 •
edited by lfrancke
Loading

Description

Part of stackabletech/issues#435

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [x] Feature Tracker has been updated
- [x] Proper release label has been added

@sbernauer sbernauer mentioned this pull request Sep 29, 2023
Closed
@sbernauer sbernauer self-assigned this Oct 5, 2023
@adwk67 adwk67 self-requested a review October 5, 2023 12:17
adwk67
adwk67 requested changes Oct 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (% minor text stuff)

@adwk67
Copy link
Copy Markdown
Member

adwk67 commented Oct 5, 2023

Smoke tests successfully tested locally.

sbernauer and others added 2 commits October 5, 2023 15:51
@sbernauer
bump: operator-rs 0.52.1
7f054b2
@sbernauer @adwk67
Apply suggestions from code review
5e9f1b7 
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
@sbernauer sbernauer requested a review from adwk67 October 5, 2023 13:53
@sbernauer sbernauer enabled auto-merge October 5, 2023 13:53
@sbernauer sbernauer added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 8501f02 Oct 5, 2023
@sbernauer sbernauer deleted the feat/support-pdb branch October 5, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@sbernauer sbernauer

Labels

release/23.11.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer @adwk67 @lfrancke