Skip to content

chore: Bump stackable-operator and product-config#585

Merged
Techassi merged 4 commits intomainfrom
chore/bump-stackable-operator
Jul 11, 2024
Merged

chore: Bump stackable-operator and product-config#585
Techassi merged 4 commits intomainfrom
chore/bump-stackable-operator

Conversation

@Techassi
Copy link
Copy Markdown
Member

@Techassi Techassi commented Jul 10, 2024

Part of stackabletech/issues#601, stackabletech/issues#557

# Reviewer
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

@Techassi Techassi self-assigned this Jul 10, 2024
@Techassi Techassi marked this pull request as ready for review July 10, 2024 09:34
@Techassi

This comment was marked as resolved.

@NickLarsenNZ NickLarsenNZ self-requested a review July 11, 2024 10:46
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit e3761ab Jul 11, 2024
@Techassi Techassi deleted the chore/bump-stackable-operator branch July 11, 2024 11:10
@sbernauer
Copy link
Copy Markdown
Member

sbernauer commented Aug 12, 2024

Hi @Techassi and @NickLarsenNZ,, I just wanted to ask why we added a changelog entry for this PR and #587?
I though according to https://github.com/stackabletech/decisions/issues/17#issuecomment-2191148634 we

Only include dependency bumps in the changelog when they introduce breaking changes

which I can not see here (druid-op users should not notice this bump). I'm currently bumping to operator-rs 0.73.0 and need to adopt the changelog again. I would be in favor of removing this changelog entries (as we did in the past), WDYT?

@NickLarsenNZ
Copy link
Copy Markdown
Member

@sbernauer, I can't answer that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants