Conversation
Contributor
Author
|
Oh, I forgot some clippy warnings. Also I'll do the merging from main |
Contributor
Author
|
There's also this issue: apache/druid#12039 that I've reported upstream. I've been testing with the psql-s3 example, that works (with an s3 config) |
Contributor
Author
|
And here's the PR for the integration tests: https://github.com/stackabletech/integration-tests/pull/59 |
siegfriedweber
requested changes
Dec 17, 2021
Contributor
Author
|
Oh, I missed the "The reconciler is called every two seconds but it should only be called on changes.". But that's actually something where I am unsure what to do. Could you maybe elaborate? |
Contributor
Author
|
The reconciler was watching endpoints by mistake. This has been removed now, thus the issue was fixed. |
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
stackable-bot
added a commit
that referenced
this pull request
Feb 1, 2022
…ackabletech/operator-templating repo. Original commit message: Updated PR Template to include a check of the helm chart (#59) * Updated PR Template to include a check of the helm chart * `make compile-chart` always rebuilds the chart. Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
bors bot
pushed a commit
that referenced
this pull request
Feb 2, 2022
Automatically created PR based on commit 718281e1f18effe44d05ff211474833f207c0e5b in stackabletech/operator-templating repo. Original commit message: Updated PR Template to include a check of the helm chart (#59) * Updated PR Template to include a check of the helm chart * `make compile-chart` always rebuilds the chart. Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com> Co-authored-by: Stacky McStackface <stackable-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review Checklist