[Merged by Bors] - Rework operator to meet the new architecture#110
Closed
siegfriedweber wants to merge 31 commits intomainfrom
Closed
[Merged by Bors] - Rework operator to meet the new architecture#110siegfriedweber wants to merge 31 commits intomainfrom
siegfriedweber wants to merge 31 commits intomainfrom
Conversation
…on to 0.2.0-nightly
maltesander
reviewed
Feb 9, 2022
Member
maltesander
left a comment
maltesander
left a comment
There was a problem hiding this comment.
Cluster was created successfully, no errors.
Some hints:
- We should reactivate the monitoring (jmx-exporter) since it was in before the rework as well
- Expose metrics ports (container and services)
- Readiness and liveness probes
- Region server http / ui port not exposed which makes it hard to get to the UI (16030)
- We could add the scraping label already?
maltesander
requested changes
Feb 11, 2022
Member
maltesander
left a comment
maltesander
left a comment
There was a problem hiding this comment.
Tested and works. Metrics up and running.
You can ignore the code comments (not that important)
But we need a full example (zookeeper cluster + hdfs + hdfs znode + hbase + hbase znode)
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2022
## Description Operator migrated to the new structure which uses StatefulSets rather than direct Pod management. [/badge/icon?subject=Integration%20Tests)](https://ci.stackable.tech/view/02%20Component%20Tests%20(flex)/job/HBase%20Operator%20Integration%20Tests%20(flex)/9/) Closes #43 ## Review Checklist - [x] Code contains useful comments - [x] (Integration-)Test cases added (or not applicable) - [x] Documentation added (or not applicable) - [x] Changelog updated (or not applicable) - [x] Cargo.toml only contains references to git tags (not specific commits or branches) - [x] Helm chart can be installed and deployed operator works (or not applicable) Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Operator migrated to the new structure which uses StatefulSets rather than direct Pod management.
Closes #43
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information