[Merged by Bors] - Add startup probe and fine-tune values in liveness and readiness probes#193
Closed
siegfriedweber wants to merge 1 commit intomainfrom
Closed
[Merged by Bors] - Add startup probe and fine-tune values in liveness and readiness probes#193siegfriedweber wants to merge 1 commit intomainfrom
siegfriedweber wants to merge 1 commit intomainfrom
Conversation
sbernauer
approved these changes
Jun 22, 2022
Member
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
LGTM
It would make sense to add a startup-probe for exactly this problem but fine for me for now
siegfriedweber
force-pushed
the
adapt_probes
branch
2 times, most recently
from
1329b62 to
12f99e8
Compare
sbernauer
approved these changes
Jul 5, 2022
Member
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
Don't forget to remove the [patch."https://github.com/stackabletech/operator-rs.git"]
siegfriedweber
force-pushed
the
adapt_probes
branch
from
12f99e8 to
63a8f01
Compare
siegfriedweber
force-pushed
the
adapt_probes
branch
from
63a8f01 to
b088c85
Compare
siegfriedweber
changed the title
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
…es (#193) # Description Add startup probe and fine-tune values in liveness and readiness probes
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add startup probe and fine-tune values in liveness and readiness probes
Integration tests
K3s on Hetzner Cloud, v1.23
Microsoft Azure AKS, 1.24.0
IONOS managed K8s, 1.23.8
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information